We build. You grow.

Get best community software here

Start a social network, a fan-site, an education project with oxwall - free opensource community software

Some suggestions for refactoring - Site-wide Advanced Search Box | Forum

Nickolay
Nickolay Mar 2 '15
Hi,


First of all thanks for this plugin, does the job well. I noticed some moments that could be improved:


1) In ISEARCH_CMP_ConsoleSearch remove inline styles for typeahead template and move it to css file. As of now it's messy and makes it harder to style the list output (only with !important hack).

2) In ISEARCH_BOL_Service class refactor db queries to use PDO params like

OW::getDbo()->queryForList($query, array('term' => '%'.$term.'%', 'page' => (int)$page, 'count' => (int)$count));

instead of inserting plain user data in query string, for security reasons.

3) To add additional oxwall event call in getSearchData method so it would be possible to include search results for any custom plugin without hacking ISearch.


Hope this helps somehow. Regards.

The Forum post is edited by Nickolay Mar 2 '15
Purusothaman Ramanujam
Thanks for these great ideas. Surely it will be considered.
You do not have permission to reply this topic