The configuration you present with user roles is a bit problematic, as I can see this causing issues in other site setups, especially if someone just installs the plugin and realises their default oxwall user role configuration has been taken over by an external plugin.
Omari, your site conception is quite specific and requires some individual configurations. Please find below explanation on how we see the configurations on your site basing on the existing functionality:
1. Create two Account Types: Teachers and Students
2. Create two Roles in addition to Free role: Teachers and Students
3. Assign the Teachers role to the Teachers account type and the Students role to the Students account type.
4. Uncheck 'Add Video' action for Free and Students roles, and check it for the Teachers role.
5. Go to the User Credits plugin settings. Select the "Teachers" account type at the top of the settings and set positive ("5") value to 'Add Video' action.
6. Switch the account type to the "Students" and click the 'Disable' button for the 'Add Video' action.
These configurations will allow you to grant Teachers by credits for the video upload and won't allow Students to upload a video.
Do not hesitate to contact us if you have further questions.