We build. You grow.

Get best community software here

Start a social network, a fan-site, an education project with oxwall - free opensource community software

SSL | Forum

Maxim Kotov
Maxim Kotov Dec 21 '15
Your function base_post_handle_https_static_content is full of bugs.

1) It doesn't recognize linebreaks inside a tags
2) It replaces external http links to https
3) What is the purpose of replacing all plain text to https?
$markup = str_replace("http:", "https:", $markup);
str_replace("http:", "https:", $matches[2][$index])
4) What is the logic of this function? Did you intent to replace all absolute links to main site?
The Forum post is edited by Maxim Kotov Dec 21 '15
tammy harris
tammy harris Dec 21 '15
this has been reported over 12 months ago and right now i am fighting with oxwall as i have 2 plugins that use https api and freaking oxwall rewrites them to http

and there reply is 

In this case you need to include the local image. Keep in mind that you need to develop the plugin compatible with Oxwall software not the opposite. 

how in hell do i make something work with something thats freaking broken 

theser always a problem show http content on a https site 

but have you ever heard problem try show https content on a http site 
tammy harris
tammy harris Dec 21 '15
i think they made it do that as some were wing that when they have a site for long time run on http and they decide to change to https lots of stuff is broken and that code rewites lots of the stuff to fix it

but to fix something for a few wingers has completely suffed everything up  
Tecca
Tecca Dec 21 '15
SSL should pretty much be 'have it from the start or not' type of thing. At least from my perspective. I don't know why any software would try to correct an indecision that a webmaster made by launching the site on HTTP then decided to add SSL. That should be left as a third-party plugin, not core functionality.


I think honestly Oxwall devs might not even use HTTPS on an Oxwall installation, hence maybe why it's not working as it should. I'm not sure though, I'm not trying to be presumptuous.


Images should simply be downloaded and served from the local site instead of attempting to pull a broken image from https when the linked site uses http. Or at the very least, give generic thumbnails to choose from while this feature is being worked on.


I guess the only reason this isn't a priority is because most people run their installations without SSL. But the sites that actually pulling in a decent income are likely running HTTPS.

tammy harris
tammy harris Dec 22 '15
we use to be able to turn ssl for pages in httacess ie for join page 

and be able turn ssl off say on blogs pages but that stuffs that up as well 
tammy harris
tammy harris Dec 22 '15
Images should simply be downloaded and served from the local site instead of attempting to pull a broken image from https when the linked site uses http. Or at the very least, give generic thumbnails to choose from while this feature is being worked on.

and a size limit on the images so it does not grab stupid things like icons 
ombeded has this but its not implicated 
i posted on this long time ago and like everything else got the answer this is a custom code mod 
tammy harris
tammy harris Dec 22 '15
the big issue is if they fix it now me and many other now have to be use full ssl on our sites because this problem and if it fixed and we want change back to http then theres a huge mess 

if they fix it it would need a button in admin to make that code run to change everthing and on its complete its run turn that code off 

i dont know maybe that not be problem go from https back to http

maybe just needs that button for ppl go from http to thhps 
ross Team
ross Dec 22 '15

Quote from Maxim Kotov Your function base_post_handle_https_static_content is full of bugs.

1) It doesn't recognize linebreaks inside a tags
2) It replaces external http links to https
3) What is the purpose of replacing all plain text to https?
$markup = str_replace("http:", "https:", $markup);
str_replace("http:", "https:", $matches[2][$index])
4) What is the logic of this function? Did you intent to replace all absolute links to main site?
Maxim what issue do you have with the linebreaks, as I believe it is a plain html?

As to changing links from http to https, yes we do that when the site is https in order to not have mixed content error and static broken links all over the website. 

The Forum post is edited by ross Dec 22 '15
Maxim Kotov
Maxim Kotov Dec 22 '15
Are you kidding?
Your function base_post_handle_https_static_content is full of bugs.

Issues are 1) 2) 3) and 4)
ok 5) issue is - your code doesn't change all links, i.e. it changes texts, not links
just look into the code



Quote from ross
Quote from Maxim Kotov Your function base_post_handle_https_static_content is full of bugs.

1) It doesn't recognize linebreaks inside a tags
2) It replaces external http links to https
3) What is the purpose of replacing all plain text to https?
$markup = str_replace("http:", "https:", $markup);
str_replace("http:", "https:", $matches[2][$index])
4) What is the logic of this function? Did you intent to replace all absolute links to main site?
Maxim what issue do you have with the linebreaks, as I believe it is a plain html?

As to changing links from http to https, yes we do that when the site is https in order to now have mixed content error and static broken links all over the website. 


ross Team
ross Dec 22 '15
Can you answer this question first, please: what issue do you have with the linebreaks, as I believe it is a plain html?
Tecca
Tecca Dec 22 '15
@Ross, linking to http websites is not mixed content or unsecure in any way. Only if it's an image or other content like iframes, but not a simple hyperlink. Links shouldn't be re-written to HTTPS, only assets like images, external javascript, etc.


Now, if every webmaster were to redirect their HTTPS://website.co/article to HTTP, this wouldn't be a problem since the s would be redirected. But that's not the case, and this will result in broken links throughout the entire Oxwall newsfeed.


Again, hyperlinks do not need to be HTTPS, only images, scripts, and iframes, etc.

Maxim Kotov
Maxim Kotov Dec 22 '15

Quote from ross Can you answer this question first, please: what issue do you have with the linebreaks, as I believe it is a plain html?

no I can't because we speak on different languages

PS every time I submit a bug report I tell myself not to do it any more because you don't understand. sad but true
oxwall is not a SAAS service, it'a a framework
The Forum post is edited by Maxim Kotov Dec 22 '15
tammy harris
tammy harris Dec 22 '15
Its absolutely  crazy rewite links 

I did make a  post here long time ago on how to turn the stupid rewrite off and last update i forgot about it 


And as search here is useless as well i can not find the post 


And ur not the only one who is sock of post bugs n post on how to do somethong 

So many have tolde they give up on oxwall and trash it and go elsewhere

tammy harris
tammy harris Dec 22 '15
this is what pisses ppl off the whole oxwall forum is full of post like these

years go by and nothing is done oxwall just think its ok no one will remember it 
or they just dont care 

http://www.oxwall.org/forum/topic/29422
http://www.oxwall.org/forum/topic/37278

and this
http://www.oxwall.org/forum/topic/43048

how hard is it to give a simple answer 
you can use css to style it out , display none
use inspect element to find the css

here is some one try make a plugin and is unanswered
http://www.oxwall.org/forum/topic/43062

everything just gets moved around 
http://www.oxwall.org/forum/topic/42471
and not answered 

i could go on and on but would take me 6 months 
tammy harris
tammy harris Dec 22 '15
some one asks something on a plugin about it not doing what it should or what ever

lets just move this to custom code mod so no one looking at the plugin will see it there 
and find out its does not do what is should do
http://www.oxwall.org/forum/topic/41572

i posted on social share plugin on it not working and it got moved to custom code mod 
with the answer this is a custom code mod 
hahhahaha
took me months to final get ross after pester him so much on it to actualy have a look and oooo yes it is a bug 
and yes it has been reported and is to be fix

but like everything else that on the to be fixed list it wont be done in the next 2 or 3 years 

oxwall needs to scrap uservoice as it does nothing 
as they just remove things as they wish 

and take a good hard look at the business model 
thats if they even have one
and rewrite it to

the 2 most important thigs that need doing 

1 fix the store

2 stop making half assed new features and fix what they have 


1 to fix the store 
have a public review board 
that each week say reviews 5 plugins 

oxwall lists the 5 plugins and the results of there review of each plugin
then use users can add any problem we have with each plugin 

oxwall then puts the findings to the dev to fix

if the dev does not at least respond or the plugin just dont work at all remove it from the store

the findings of each review should be listed on the plugins page 
and the dev can respond to each item with 
this will be fixed in 2 week
this will be fixed in 2 months
this will be fixed in 3 months

and when each item is fixed the dev can mark it as fixed 

2 make another discussion board thing 
and list the huge amount of known bugs and known things in the to be fixed list 

then give all oxwall users 2 votes to vote on what they would like to be fixed 
each update the top 5 on the list gets fixed 
anyone who voted on any of the top 5 on it being fixed gets there vote back to vote on something else

then have a forum just for post on things that ppl find that should be added to the list 
so instead of get the answer tis will be fixed in an upcoming build 
it gets added to the list where everyone can see it

doing like this is will everyone the faith and trust in oxwall that everyone has lost 
and open the transparency of oxwall and make oxwall grow into something awesome 








tammy harris
tammy harris Dec 22 '15
even have a say once every month or 2 months a crowdfunding bug fix 
so say some the known bugs in the list are  big fixes 
have oxwall have the right on say 1 out of the 5 that have been votes to be fixed to mark it as a big fix it then goes into the big fix list 
when the list gets to 10 have a croudfunding 
and say to fix the 10 oxwall needs $400 
when the 400 target is reached wooooohooo they get fixed 

i and many others do not have a problem in donating money to oxwall to get things we know that are going to be fixed 
tammy harris
tammy harris Dec 22 '15
oxwall has done a lot of hard work to get oxwall to where it is 
and i dont have a problem with helping to make it better 

there maybe 20 things now that i would be happy to put $100 towards to be fixed 

but stuffed if i am just going to use the donate to oxwall development button and not know what my money is going towards 
ross Team
ross Dec 22 '15
Regarding rewriting http links to https when ssl is enabled, this issue has been reported to our devs a while ago, it will be fixed in one of the upcoming updates. 


I was wondering what issue Maxim has with the linebreaks

tammy harris
tammy harris Dec 22 '15
what about fixing the rewrite https back to http on none ssl sites 

and no comments on anything i said

ross Team
ross Dec 22 '15
What do you mean it rewrites https to http? How can we reproduce that? 
Pages: 1 2 »