We build. You grow.

Get best community software here

Start a social network, a fan-site, an education project with oxwall - free opensource community software

Double Value= on join form submit input statement [Solved] | Forum

dave Leader
dave May 28 '13

Hi i noticed on the form  id="joinForm" on the input submit statement you have double value= 

 

it shows twice wether it is value of "continue" or value of "submit" 

The Forum post is edited by Alia Jun 7 '13
Alia Team
Alia Jun 4 '13
Dave, in which file have you looked at? ( screen shot is appreciated).
dave Leader
dave Jun 4 '13

Hi Aliia,

 

Go to he oxwall demo (figured it was better to show you that way)  click on join,  do page source and look at line 1350

 

<inputtype="submit"value="Join"id="input_45614257"class="ow_button ow_ic_submit"name="joinSubmit"value="Join"/>

 

double value attributes in input

 

:)

 

ps prob would not hurt to put some spaces between the attributes as well.

The Forum post is edited by dave Jun 4 '13
Alia Team
Alia Jun 5 '13
Thanks for pointing out Dave. We have fixed that. Fix will be released with the next upcoming build.

Here is what needs to be done:

ow_core/form_elements.php, line 963.

Replace following code:

 public function renderInput( $params = null )
    {
        parent::renderInput($params);
 
        $this->addAttribute('value', $this->getValue());
 
        if ( $params === null )
        {
            $params = array();
        }
 
        $params = array_merge($params, $this->attributes);
        $params['label'] = $params['value'];
 
        $extraString = '';
 
        foreach ( $this->attributes as $attr => $val )
        {
            if ( !in_array($attr, array('class', 'id', 'buttonName', 'langLabel', 'label', 'type')) )
            {
                $extraString .= $attr . '="' . $val . '"';
            }
        }
 
        $params['extraString'] = $extraString;
 
        return OW::getThemeManager()->processDecorator('button', $params);
      }
    }



with this one:

 public function renderInput( $params = null )
    {
        parent::renderInput($params);
 
        $this->addAttribute('value', $this->getValue());
 
        if ( $params === null )
        {
            $params = array();
        }
 
        $params = array_merge($params, $this->attributes);
        $params['label'] = $params['value'];
 
        $extraString = '';
 
        foreach ( $this->attributes as $attr => $val )
        {
            if ( !in_array($attr, array('class', 'id', 'buttonName', 'langLabel', 'label', 'type', 'value')) )
            {
                $extraString .= $attr . '="' . $val . '" ';
            }
        }
 
        $params['extraString'] = $extraString;
 
        return OW::getThemeManager()->processDecorator('button', $params);
        }
    }

dave Leader
dave Jun 5 '13
Thanks :)
dave Leader
dave Jun 5 '13

fyi just in case anyone asks if they get a 500 error after this..   they prob took out the closing function } bracket and did not put it back.    I would recommend Aliia just to save some hassle to put the closing } on your post for the old and the new so they dont do that. :)

 

it should be

 

    return OW::getThemeManager()->processDecorator('button', $params);
    }

}

on both old and new examples  :)

 

Also folks pay attention to the line number she mentions, as there are several of these functions renderInput  

The Forum post is edited by dave Jun 5 '13
dave Leader
dave Feb 12 '14
Looks like our issue is back and i cant do this fix because the function has been changed severely in 1.6  


the issue is back on the registration form in two places.    (i have my reg set up as multiple pages) 


after password 


value="Sign In" is listed twice


<div class="ow_form_options clearfix"> <div class="ow_right"> <span class="ow_button ow_positive"><span><input type="submit" value="Sign In" id="input_90332713" class="ow_positive"name="submit"value="Sign In" /></span></span> </div>




and the second at the end of the form 


value="Continue" is listed twice


<tr class="ow_tr_delimiter"><td></td></tr> </table> <div class="clearfix"> <div class="ow_right"> <span class="ow_button ow_button ow_ic_submit"><span><input type="submit" value="Continue" id="input_69175295" class="ow_button ow_ic_submit"name="joinSubmit"value="Continue" /></span></span> </div> </div> </form>


ross Team
ross Feb 17 '14
Dave thank you very much for catching it again. I have reported it to the tech staff they'll provide a fix asap and it will be added in the next update. 
Mitchell Thornton
Hi there, I discovered your blog per Google bit searching for such kinda educational advise moreover your inform beholds very remarkable for me. bitcoin ATM Calgary
Mitchell Thornton
On this page you can read my interests, write something special. slot gacor
Alex Jones
Alex Jones Jul 2
Custom kitchen cabinets allow you to choose from a wide range of materials, finishes, and hardware to create a look that reflects your personal style. custom kitchen cabinets
Alex Jones
Alex Jones Oct 9
At the intersection of wanderlust, sustainability, and luxury living, Là Fuori connects 'nomadic hearts' driven by a mission to elevate and safeguard artisanal traditions worldwide. La Fuori