We build. You grow.

Get best community software here

Start a social network, a fan-site, an education project with oxwall - free opensource community software

[BUG] Tiny improvement for Social Auth | Forum

Nickolay
Nickolay Apr 1 '15
1) I noticed that OW_AuthAdapter::isRegistered() method checks only remoteId field, though in all available auth plugins (googl/fb/vk) it is specified as integer, so checking type is really neccessary so there will be collisions between different types with the same remote ids.

2) In fbconnect and vkconnect plugins synchonization functionality only replaces profile data, but it's not creating new BOL_RemoteAuth info. Just calling OW_AuthAdapter::register() method there will allow users to connect more than one social profile to their accoount in Oxwall.

ross Team
ross Apr 2 '15
Thanks for sharing, I'll pass it to our developers and get back to you with their feedback
Nickolay
Nickolay Apr 2 '15
P.S. Plus there's a bug in OW_RemoteAuthAdapter::getRemoteId() method - it returns some non-existing $this->remoteUserId param, though a right one is $this->remoteId.
The Forum post is edited by Nickolay Apr 2 '15
ross Team
ross Apr 7 '15
Thanks Nickolay, I have passed it to our developers, they said that all you said is valid, it will be fixed in one of the upcoming updates.